Viewfinder toggle #137
Merged
Viewfinder toggle #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging |
|
Seems to be working perfectly well for me locally! ✨ However I had totally pictured the toggle to be on the top right corner of the screen and not in the menu bar! Kind of like the "Controls" button when the sidebar menu is closed. Perhaps we should ask later in our sync what they prefer! In my mind the sidebar is just to manipulate/visualise the dataset, so I wouldn't necessarily put an item in there that controls the viewfinder. |
hannahker
reviewed
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let user disable/enable the viewfinder
todo in the future: once the user loading data is implemented, save the viewfinder toggle state and load it when the user returns. Eg when they disable it and come back, it should be automatically disabled